Merge pull request #511 from spring-operator/polish-urls-remaining-master

URL Cleanup

(cherry picked from commit c94acb8c)

Conflicts:
	attributes/default.rb

CONTRIBUTING.md

@@ -130,7 +130,7 @@ to them.
 
 This cookbook is set up to run tests under
 [Kitchen-ci's test-kitchen](https://github.com/test-kitchen/test-kitchen).
-It uses [inspec](http://inspec.io) to perform integration tests after the node
+It uses [inspec](https://inspec.io) to perform integration tests after the node
 has been converged.
 
 Test kitchen should run completely without exception using the default
@@ -182,7 +182,7 @@ The versioning for Chef Cookbook projects is X.Y.Z.
 
 Releases of Chef's cookbooks are usually announced on the Chef user
 mailing list. Releases of several cookbooks may be batched together
-and announced on the [Chef Blog](http://www.chef.io/blog).
+and announced on the [Chef Blog](https://www.chef.io/blog).
 
 ## Working with the community
 
@@ -190,18 +190,18 @@ These resources will help you learn more about Chef and connect to
 other members of the Chef community:
 
 * [openstack cookbook group](https://groups.google.com/forum/#!forum/opscode-chef-openstack)
-* [chef](http://lists.chef.io/sympa/info/chef) and
-  [chef-dev](http://lists.chef.io/sympa/info/chef-dev) mailing
+* [chef](http://lists.opscode.com/sympa/info/chef) and
+  [chef-dev](http://lists.opscode.com/sympa/info/chef-dev) mailing
   lists
 * #openstack-chef, #chef, #chef-hacking IRC channels on irc.freenode.net
-* Chef, Inc [product page](http://www.chef.io/chef)
+* Chef, Inc [product page](https://www.chef.io/chef)
 
 ## Cookbook Contribution Do's and Don't's
 
 Please do include tests for your contribution. If you need help, ask
 on the [openstack cookbook group](https://groups.google.com/forum/#!forum/opscode-chef-openstack)
-or the [chef-dev mailing list](http://lists.chef.io/sympa/info/chef-dev)
-or the [#chef-hacking IRC channel](http://community.chef.io/chat/chef-hacking).
+or the [chef-dev mailing list](http://lists.opscode.com/sympa/info/chef-dev)
+or the [#chef-hacking IRC channel](https://community.chef.io/chat/chef-hacking).
 
 Not all platforms that a cookbook supports may be supported by Test
 Kitchen. Please provide evidence of testing your contribution if it

README.md

@@ -36,7 +36,7 @@ will go out of vendor support in 2019.
 ## Dependencies
 
 This cookbook depends on the [Erlang cookbook](https://supermarket.chef.io/cookbooks/erlang)
-and assumes that the user can configure it to provision a [supported Erlang/OTP version](http://www.rabbitmq.com/which-erlang.html).
+and assumes that the user can configure it to provision a [supported Erlang/OTP version](https://www.rabbitmq.com/which-erlang.html).
 
 Two more recipes are provided by this cookbook:`rabbitmq::erlang_package` and `rabbitmq::esl_erlang_package`.
 The latter is an alias to the `erlang::esl` recipe in the Erlang
@@ -362,9 +362,9 @@ in the RabbitMQ [Access Control guide](https://www.rabbitmq.com/access-control.h
 
 ##### Definitions Import
 
-[RabbitMQ management plugin](http://www.rabbitmq.com/management.html) provides a means to load a definitions
-(schema) file on node boot. See [Definitions Export and Import](http://www.rabbitmq.com/management.html#load-definitions)
-and [Backup](http://www.rabbitmq.com/backup.html) guides for details.
+[RabbitMQ management plugin](https://www.rabbitmq.com/management.html) provides a means to load a definitions
+(schema) file on node boot. See [Definitions Export and Import](https://www.rabbitmq.com/management.html#load-definitions)
+and [Backup](https://www.rabbitmq.com/backup.html) guides for details.
 
 To configure definition loading, set the following attribute:
 
@@ -414,7 +414,7 @@ node['rabbitmq']['enabled_users'] = [
 Note that with this approach user credentials will be stored in the attribute file.
 Using encrypted data bags is therefore highly recommended.
 
-Alternatively [definitions export and import](http://www.rabbitmq.com/management.html#load-definitions) (see above) can be used.
+Alternatively [definitions export and import](https://www.rabbitmq.com/management.html#load-definitions) (see above) can be used.
 Definition files contain password hashes since clear text values are not stored.
 
 ### vhosts
@@ -426,7 +426,7 @@ Configures a cluster of nodes.
 
 It supports two clustering modes: auto or manual.
 
-* Auto clustering: lists [cluster nodes in the RabbitMQ config file](http://www.rabbitmq.com/cluster-formation.html#peer-discovery-classic-config). Those are taken from lists the nodes `node['rabbitmq']['clustering']['cluster_nodes']`.
+* Auto clustering: lists [cluster nodes in the RabbitMQ config file](https://www.rabbitmq.com/cluster-formation.html#peer-discovery-classic-config). Those are taken from lists the nodes `node['rabbitmq']['clustering']['cluster_nodes']`.
 * Manual clustering : Configure the cluster by executing `rabbitmqctl join_cluster` command.
 
 #### Attributes

attributes/default.rb

@@ -51,7 +51,7 @@ default['rabbitmq']['retry'] = 0
 default['rabbitmq']['retry_delay'] = 2
 
 # config file location
-# http://www.rabbitmq.com/configure.html#define-environment-variables
+# https://www.rabbitmq.com/configure.html#define-environment-variables
 # "The .config extension is automatically appended unless a file extension is already present."
 default['rabbitmq']['config_root'] = '/etc/rabbitmq'
 default['rabbitmq']['config'] = "#{node['rabbitmq']['config_root']}/rabbitmq"
@@ -72,7 +72,7 @@ default['rabbitmq']['default_pass'] = 'guest'
 default['rabbitmq']['loopback_users'] = nil
 
 # Erlang kernel application options
-# See http://www.erlang.org/doc/man/kernel_app.html
+# See https://www.erlang.org/doc/man/kernel_app.html
 default['rabbitmq']['kernel']['inet_dist_listen_min'] = nil
 default['rabbitmq']['kernel']['inet_dist_listen_max'] = nil
 
@@ -87,12 +87,12 @@ default['rabbitmq']['clustering']['use_auto_clustering'] = false
 default['rabbitmq']['clustering']['cluster_name'] = nil
 default['rabbitmq']['clustering']['cluster_nodes'] = []
 
-# Manual clustering
-# - Node type : master | slave
-default['rabbitmq']['clustering']['node_type'] = 'master'
-# - Master node name : ex) rabbit@rabbit1
-default['rabbitmq']['clustering']['master_node_name'] = 'rabbit@rabbit1'
-# - Cluster node type : disc | ram
+## Chef-driven clustering.
+##
+## Note that there are no leader/master or follower nodes in RabbitMQ,
+## all nodes are equal peers: https://www.rabbitmq.com/clustering.html#peer-equality
+default['rabbitmq']['clustering']['node_type']         = 'master'
+default['rabbitmq']['clustering']['master_node_name']  = 'rabbit@rabbit1'
 default['rabbitmq']['clustering']['cluster_node_type'] = 'disc'
 
 # log levels

test/erlang_package/latest_deb/default_spec.rb

 # The Inspec reference, with examples and extensive documentation, can be
-# found at http://inspec.io/docs/reference/resources/
+# found at https://inspec.io/docs/reference/resources/
 
 %w(
   erlang-asn1 erlang-crypto erlang-public-key erlang-ssl erlang-syntax-tools

test/erlang_package/latest_rpm/default_spec.rb

 # The Inspec reference, with examples and extensive documentation, can be
-# found at http://inspec.io/docs/reference/resources/
+# found at https://inspec.io/docs/reference/resources/
 
 describe package('erlang') do
   it { should be_installed }

test/erlang_package/pinned_deb/default_spec.rb

 # The Inspec reference, with examples and extensive documentation, can be
-# found at http://inspec.io/docs/reference/resources/
+# found at https://inspec.io/docs/reference/resources/
 
 %w(
   erlang-asn1 erlang-crypto erlang-public-key erlang-ssl erlang-syntax-tools

test/erlang_package/pinned_rpm/default_spec.rb

 # The Inspec reference, with examples and extensive documentation, can be
-# found at http://inspec.io/docs/reference/resources/
+# found at https://inspec.io/docs/reference/resources/
 
 describe package('erlang') do
   it { should be_installed }

test/integration/cluster/default_spec.rb

 # The Inspec reference, with examples and extensive documentation, can be
-# found at http://inspec.io/docs/reference/resources/
+# found at https://inspec.io/docs/reference/resources/
 
 describe file('/var/lib/rabbitmq/.erlang.cookie') do
   it { should be_file }

test/integration/default/default_spec.rb

 # The Inspec reference, with examples and extensive documentation, can be
-# found at http://inspec.io/docs/reference/resources/
+# found at https://inspec.io/docs/reference/resources/
 
 describe package('rabbitmq-server') do
   it { should be_installed }

test/integration/limits/default_spec.rb

 # The Inspec reference, with examples and extensive documentation, can be
-# found at http://inspec.io/docs/reference/resources/
+# found at https://inspec.io/docs/reference/resources/
 
 describe package('rabbitmq-server') do
   it { should be_installed }

test/integration/lwrps/default_spec.rb

 # The Inspec reference, with examples and extensive documentation, can be
-# found at http://inspec.io/docs/reference/resources/
+# found at https://inspec.io/docs/reference/resources/
 
 describe command('curl -u guest:guest -H "Accept: application/json" -X GET "http://localhost:15672/api/overview"') do
   its(:exit_status) { should eq 0 }

test/integration/management_plugin/default_spec.rb

 # The Inspec reference, with examples and extensive documentation, can be
-# found at http://inspec.io/docs/reference/resources/
+# found at https://inspec.io/docs/reference/resources/
 
 describe package('rabbitmq-server') do
   it { should be_installed }