Signed-off-by: Tim Smith <tsmith@chef.io>

Obvious fix; these changes are the result of automation not creative thinking.

Obvious fix; these changes are the result of automation not creative thinking.

Signed-off-by: Tim Smith <tsmith@chef.io>

Signed-off-by: Tim Smith <tsmith@chef.io>

Co-authored-by: pete higgins <pete@peterhiggins.org>

Signed-off-by: Tim Smith <tsmith@chef.io>

Co-authored-by: pete higgins <pete@peterhiggins.org>

Signed-off-by: Tim Smith <tsmith@chef.io>

Co-authored-by: pete higgins <pete@peterhiggins.org>

This spec actually ran the code and it would fail if you had node
installed.

Signed-off-by: Tim Smith <tsmith@chef.io>

We have our own which helper in the DSL now, which takes 2 args. This
helper is getting injected over it, which works most of the time (not as
well), but doesn't work when someone passes additional args. This breaks
gem_package and probably some other things in the ecosystem. We need to
continue to support chef-sugar being installed on a modern chef-client
release since that's necessary for client upgrades, but we should not
allow the injection of a legacy helper over the built-in.

Signed-off-by: Tim Smith <tsmith@chef.io>

Obvious fix; these changes are the result of automation not creative thinking.

Obvious fix; these changes are the result of automation not creative thinking.

Only require libs if we haven't already loaded them

Signed-off-by: Tim Smith <tsmith@chef.io>

Rubygems is very slow at requiring files so only do it if we really need
to.

Signed-off-by: Tim Smith <tsmith@chef.io>

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

Obvious fix; these changes are the result of automation not creative thinking.

Fix Ruby 2.3 tests

rubyzip no longer supports ancient Ruby

Signed-off-by: Tim Smith <tsmith@chef.io>

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

Obvious fix; these changes are the result of automation not creative thinking.

Obvious fix; these changes are the result of automation not creative thinking.

Don't fail if Chef::VERSION isn't defined

this allows chef-sugar to continue to be used with omnibus

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

Obvious fix; these changes are the result of automation not creative thinking.

Obvious fix; these changes are the result of automation not creative thinking.

Deprecate chef-sugar node API

Obvious fix; these changes are the result of automation not creative thinking.

Get the tests green

Signed-off-by: Tim Smith <tsmith@chef.io>

Signed-off-by: Tim Smith <tsmith@chef.io>

Remove the gem tasks from the Rakefile
Move kitchen gems to their own group
Require an older chefspec that works on more Ruby releases

Signed-off-by: Tim Smith <tsmith@chef.io>

This will not be pulled into core chef.  The conventional
chef node attributes API should be used instead.

- The `#in?` helper is dropped as being too trivial

- The deep fetch API was implemented ages ago in `node.read[!]`

- The namespace API will not be accepted into core due to the
  utilization of method_missing.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

Obvious fix; these changes are the result of automation not creative thinking.

Move test deps to the Gemfile

This is how we do it in our other gems

Signed-off-by: Tim Smith <tsmith@chef.io>

Obvious fix; these changes are the result of automation not creative thinking.

Additional Chef-15 greenification